Fix #1127 - Apply late feedback of PR #1126 #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ricardozanini the follow up of #1126 |
gabriel-farache
force-pushed
the
fix/oauth2_provider_credentialProvider_bis
branch
2 times, most recently
from
52ff5d5 to
bb77674
Compare
Member
|
These changes are fine, we just have to change the constructor as I mentioned in #1126 |
Contributor
Author
|
Constructors removed in #1176 |
gmunozfe
approved these changes
Jun 9, 2025
Contributor
There was a problem hiding this comment.
Looks good to me, just resolve the conflicts before merge, well done @gabriel-farache !
ricardozanini
approved these changes
Jun 9, 2025
Signed-off-by: gabriel-farache <[email protected]>
gabriel-farache
force-pushed
the
fix/oauth2_provider_credentialProvider_bis
branch
from
bb77674 to
006df17
Compare
gmunozfe
approved these changes
Jun 10, 2025
Contributor
gmunozfe
left a comment
gmunozfe
left a comment
There was a problem hiding this comment.
Well done @gabriel-farache !
ricardozanini
pushed a commit
to ricardozanini/quarkus-openapi-generator
that referenced
this pull request
Jun 18, 2025
Signed-off-by: gabriel-farache <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.